Fix SonarCloud issues

CHANGELOG.MD

@@ -1,6 +1,6 @@
 ## June 26, 2024
 
-- **Feature** Redesigned Engagement Cards & added Suggested Engagements to the engagement page
+- **Feature** Redesigned Engagement Cards & added Suggested Engagements to the engagement page [🎟️ DESENG-634](https://citz-gdx.atlassian.net/browse/DESENG-634)
   - Redesigned the engagement cards to match the new design system
   - Added a new section to the engagement page to display suggested engagements
   - Engagement cards now take you to the "new look" route

met-web/src/components/common/Indicators/StatusChip.tsx

@@ -5,7 +5,6 @@ import { SubmissionStatus } from 'constants/engagementStatus';
 
 export interface ChipProps {
     label?: string;
-    invert?: boolean;
     statusId: SubmissionStatus;
 }
 

met-web/src/components/engagement/new/view/EngagementSurveyBlock.tsx

@@ -2,7 +2,7 @@ import React, { Suspense } from 'react';
 import { Button } from 'components/common/Input';
 import { Box, Grid, Skeleton, ThemeProvider } from '@mui/material';
 import { colors } from 'components/common';
-import { Await, Link, useLoaderData, useParams } from 'react-router-dom';
+import { Await, Link, LinkProps, useLoaderData, useParams } from 'react-router-dom';
 import { Engagement } from 'models/engagement';
 import { SubmissionStatus } from 'constants/engagementStatus';
 import { getStatusFromStatusId } from 'components/common/Indicators/StatusChip';
@@ -31,6 +31,10 @@ const gridContainerStyles = {
     flexDirection: { xs: 'column', md: 'row' },
 };
 
+const LinkRenderer: React.ElementType<any> = ({ href, ...props }: Omit<LinkProps, 'to'> & { href: string }) => (
+    <Link to={href} {...props} />
+);
+
 export const EngagementSurveyBlock = () => {
     const { engagement, widgets } = useLoaderData() as { engagement: Promise<Engagement>; widgets: Promise<Widget[]> };
     const surveyBlockContents = Promise.all([engagement, widgets]);
@@ -149,11 +153,7 @@ export const EngagementSurveyBlock = () => {
                                                             ? `/engagements/${engagement.id}/dashboard/public`
                                                             : `/engagements/${engagement.id}/dashboard/public/${language}`
                                                     }
-                                                    LinkComponent={({ children, href, ...props }) => (
-                                                        <Link to={href} {...props}>
-                                                            {children}
-                                                        </Link>
-                                                    )}
+                                                    LinkComponent={LinkRenderer}
                                                 >
                                                     {translate('buttonText.viewFeedback')}
                                                 </Button>

met-web/src/components/landing/EngagementTile.tsx

@@ -1,7 +1,6 @@
 import React, { useEffect, useState } from 'react';
-import { Card, CardContent, CardMedia, CardActionArea, ThemeProvider } from '@mui/material';
+import { Box, Grid, Card, CardContent, CardMedia, CardActionArea, ThemeProvider } from '@mui/material';
 import { Engagement } from 'models/engagement';
-import { Box, Grid } from '@mui/material';
 import { getEngagement } from 'services/engagementService';
 import dayjs from 'dayjs';
 import { EngagementStatusChip } from 'components/common/Indicators/StatusChip';

met-web/src/styles/Theme.ts

@@ -1,4 +1,3 @@
-import { Contrast } from '@mui/icons-material';
 import { PaletteMode, createTheme } from '@mui/material';
 export const colors = {
     type: {