feat: Disable new versions if there is already a draft #2453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dhaselhan
commented
Apr 10, 2025
dhaselhan
commented
- Add is newest_flag to report chain to confirm whether newer versions exist, but dont return their data
- Use this flag to control the supplemental and assessment buttons with dialogs + text
Backend Test Results675 tests 675 ✅ 2m 36s ⏱️ Results for commit 69466dc. ♻️ This comment has been updated with latest results. |
Frontend Test Results 1 files 152 suites 1m 7s ⏱️ Results for commit 69466dc. ♻️ This comment has been updated with latest results. |
dhaselhan
force-pushed
the
feat/daniel-disable-double-draft-2376
branch
3 times, most recently
from
aa131b7 to
f3379c3
Compare
AlexZorkin
approved these changes
Apr 14, 2025
| report.compliance_report_group_uuid | ||
| ) | ||
|
|
||
| is_newest = len(compliance_report_chain) - 1 == report.version |
| title={ | ||
| reportData.isNewest | ||
| ? '' | ||
| : 'Government has a reassessment in progress.' |
There was a problem hiding this comment.
Just want to confirm that business area is ok with telling suppliers this is the case?
dhaselhan
force-pushed
the
feat/daniel-disable-double-draft-2376
branch
2 times, most recently
from
ebf32f9 to
135cf3a
Compare
* Add is newest_flag to report chain to confirm whether newer versions exist, but dont return their data * Use this flag to control the supplemental and assessment buttons with dialogs + text
dhaselhan
force-pushed
the
feat/daniel-disable-double-draft-2376
branch
from
135cf3a to
69466dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.