Skip to content

Feat: LCFS - BCeID Credit calculator - 2308 #2398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 14, 2025

Conversation

prv-proton
Copy link
Collaborator

Feat: #2308

Copy link

github-actions bot commented Apr 8, 2025

Backend Test Results

675 tests   675 ✅  2m 36s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 1ff3107.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 8, 2025

Frontend Test Results

  1 files  152 suites   1m 8s ⏱️
635 tests 615 ✅ 20 💤 0 ❌
637 runs  617 ✅ 20 💤 0 ❌

Results for commit 1ff3107.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great but I have one thought about the /public endpoint. I think we should use /calculator as the url, and just add that to the auth exception. /public is an extra layer that I don't think we need. If we ever add more public features the PublicRepository/Service would get crowded so having CalculatorRepository/Service is more defined. let me know what you think.

@prv-proton
Copy link
Collaborator Author

This all looks great but I have one thought about the /public endpoint. I think we should use /calculator as the url, and just add that to the auth exception. /public is an extra layer that I don't think we need. If we ever add more public features the PublicRepository/Service would get crowded so having CalculatorRepository/Service is more defined. let me know what you think.

Thanks for the feedback, please review the fixed code.

@prv-proton prv-proton requested a review from AlexZorkin April 14, 2025 19:06
Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the updates, looks good 👍

@prv-proton prv-proton merged commit 3aef4d3 into develop Apr 14, 2025
13 checks passed
@prv-proton prv-proton deleted the feat/prashanth-credit-calc-2308 branch April 14, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants