-
Notifications
You must be signed in to change notification settings - Fork 3
Feat: LCFS - BCeID Credit calculator - 2308 #2398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Backend Test Results675 tests 675 ✅ 2m 36s ⏱️ Results for commit 1ff3107. ♻️ This comment has been updated with latest results. |
Frontend Test Results 1 files 152 suites 1m 8s ⏱️ Results for commit 1ff3107. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks great but I have one thought about the /public endpoint. I think we should use /calculator as the url, and just add that to the auth exception. /public is an extra layer that I don't think we need. If we ever add more public features the PublicRepository/Service would get crowded so having CalculatorRepository/Service is more defined. let me know what you think.
Thanks for the feedback, please review the fixed code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the updates, looks good 👍
Feat: #2308