Feature/deseng536 Redirect landuseplanning.gov.bc.ca to planninginpartnership.ca #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Baelx
commented
Jul 29, 2024
•
Baelx
commented
- Remove commands that copy nginx config to container
- Create configmaps to store nginx config per-project
- Modify deployment configs to use mounted configmaps
- Fix local build issue by inputting proper package.json version and removing build step
- Remove commented-out nginx config
NatSquared
approved these changes
Jul 29, 2024
| server_name localhost; | ||
| listen 8080; | ||
| server_name landuseplanning.gov.bc.ca; | ||
| rewrite ^/(.*)$ https://planninginpartnership.ca/$1 permanent; |
There was a problem hiding this comment.
Looks like a standard permanent redirect 👍
| # set_real_ip_from %RealIpFrom%; | ||
| #%AdditionalRealIpFromRules% | ||
| # real_ip_recursive on; | ||
| # real_ip_header X-Forwarded-For; |
There was a problem hiding this comment.
Thanks for doing this cleanup!
| @@ -1,3 +1,5 @@ | |||
| # This nginx server config now lives in ConfigMaps (nginx-conf) in the dev, test, prod projects respectively | |||
There was a problem hiding this comment.
Sounds good! Thanks for maintaining this copy; good to know we're using a more flexible system now
Thanks Nat! It's technically not a new site, but just two different domains that point to the same site. For branding purposes, we don't want the landuseplanning URL persisting in the production site but for it to always redirect such that the address bar populates with planninginpartnership.ca |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.