Skip to content

Commit

Permalink
comments for 0.4.1 submission
Browse files Browse the repository at this point in the history
  • Loading branch information
jongoetz committed Dec 10, 2021
1 parent 244eed5 commit a88628b
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 1 deletion.
2 changes: 1 addition & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Updated: 10 Dec 2021

#### Updates:

* Fixed major bug: Seasons identifiers were mislabeled when water_year_start > 1
* Fixed major bug: Seasons identifiers were mislabeled when water_year_start > 1 for add_seasons() and various functions use seasonal cumulative totals
* Updated documentation - 'months' and other param descriptions
* plot_flow_duration() - removed annotation ticks when not in log-scale
* added 'log_ticks' argument to customize adding annotation_ticks or not when log scale
Expand Down
28 changes: 28 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,31 @@
fasstr 0.4.1
=========================

## Submission

2021-12-10 - update with important bug fix since last submission (6 days ago)


## Test environments

* win-builder (via `devtools::check_win_devel()` and `devtools::check_win_release()`)
* local Windows 10, R 4.1.2 (via R CMD check --as-cran)
* macOS-latest (release) (via GitHub actions R-CMD-check)
* windows-latest (release) (via GitHub actions R-CMD-check)
* ubuntu-latest (devel) (via GitHub actions R-CMD-check)
* ubuntu-latest (release) (via GitHub actions R-CMD-check)
* ubuntu-latest (oldrel-1) (via GitHub actions R-CMD-check)
* Fedora Linux, R-devel, clang, gfortran - r-hub
* Ubuntu Linux 20.04 LTS, R-release, GCC - r-hub
* Debian Linux, R-devel, GCC - r-hub
* Windows Server 2008 R2 SP1, R-devel, 32/64 bit - r-hub
* Windows Server 2008 R2 SP1, R-release, 32/64 bit - r-hub
* macOS 10.13.6 High Sierra, R-release, brew - r-hub
* macOS 10.13.6 High Sierra, R-release, CRAN's setup - r-hub

## R CMD check results
There were no ERRORs or WARNINGs or NOTES.

fasstr 0.4.0
=========================

Expand Down
1 change: 1 addition & 0 deletions release_process.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ R CMD check fasstr_0.3.2.tar.gz --as-cran ## or whatever fasstr version number
## Documentation
- Update NEWS
- Update cran-comments
- Update /docs for Github Page

## Actually release it
```
Expand Down

0 comments on commit a88628b

Please sign in to comment.