GET /object: only blacklist path instead of whitelisting a limited subset of params
#314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No-auth search is already scoped by requiring a bucketId, so allowing the other params is safe. `path` is still blocked though, as it can expose the underlying S3 directory structure.
norrisng-bc
requested review from
TimCsaky and
jatindersingh93
as code owners
Coverage Report
|
TimCsaky
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a slight tweak to #312 .
When calling
GET /object(search objects) without authentication, instead of whitelisting a limited subset of search parameters (bucketId,objectId,public,page,limit,sort), all parameters except forpathare now allowed.The other restrictions while no-auth remain; i.e. requiring a
bucketIdorobjectId,?public=trueand redaction of some response fields.No-auth object searches are already scoped by
bucketId, so allowing other parameters is safe. However,pathwill still be blocked as it can potentially expose the underlying S3 bucket directory structure.This allows the object filters in BCBox's
<ObjectTable>to work without authentication (i.e. for displaying public folders).Other tweaks:
https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3969
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments
N/A