Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add django-querycount package #3097

Merged
merged 3 commits into from
Mar 27, 2025
Merged

Conversation

Sepehr-Sobhani
Copy link
Contributor

No description provided.

Copy link
Contributor

@andrea-williams andrea-williams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way to set default settings for querycount that all devs could share? Otherwise I could see there might be some problems if the high/medium/etc. thresholds are configured differently for each dev

@Sepehr-Sobhani
Copy link
Contributor Author

is there a way to set default settings for querycount that all devs could share? Otherwise I could see there might be some problems if the high/medium/etc. thresholds are configured differently for each dev

Since we are not defining those thresholds, the package uses the default setting in: https://github.com/bradmontgomery/django-querycount/blob/main/querycount/qc_settings.py

@Sepehr-Sobhani Sepehr-Sobhani force-pushed the chore/django-querycount-package branch 2 times, most recently from 432520f to 15bf964 Compare March 27, 2025 15:52
@Sepehr-Sobhani
Copy link
Contributor Author

@andrea-williams made a small tweak to show the 2 most duplicated SQL queries in terminal:
Screenshot 2025-03-27 at 10 11 35 AM

@Sepehr-Sobhani Sepehr-Sobhani force-pushed the chore/django-querycount-package branch from a31b2ae to 3958fdd Compare March 27, 2025 22:45
@Sepehr-Sobhani Sepehr-Sobhani force-pushed the chore/django-querycount-package branch from 3958fdd to 4d70cf2 Compare March 27, 2025 23:24
@Sepehr-Sobhani Sepehr-Sobhani merged commit 13cbb07 into develop Mar 27, 2025
21 checks passed
@Sepehr-Sobhani Sepehr-Sobhani deleted the chore/django-querycount-package branch March 27, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants