Database cleanup (remove obsolete fields) #3032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrea-williams
force-pushed
the
task/database-cleanup/2229
branch
2 times, most recently
from
a0114cf to
b6cf7dd
Compare
andrea-williams
force-pushed
the
task/database-cleanup/2229
branch
2 times, most recently
from
8362df0 to
d91b93d
Compare
andrea-williams
force-pushed
the
task/database-cleanup/2229
branch
2 times, most recently
from
187ec3f to
d6b50aa
Compare
Sepehr-Sobhani
approved these changes
Mar 26, 2025
bc_obps/registration/utils.py
Outdated
| @@ -126,7 +124,7 @@ def custom_reverse_lazy(view_name: str, *args: Any, **kwargs: DictStrAny) -> Uni | |||
| return reverse_lazy(f"{DEFAULT_API_NAMESPACE}:{view_name}", *args, **kwargs) | |||
|
|
|||
|
|
|||
| def set_verification_columns(record: Union[UserOperator, Operator, Operation], user_guid: UUID) -> None: | |||
| def set_verification_columns(record: UserOperator, user_guid: UUID) -> None: | |||
There was a problem hiding this comment.
We are now using this in one place. Should we move it there or create a function for it under the UserOperator service?
There was a problem hiding this comment.
ooh good point! I'll check with Reporting first - I wonder if they'll have a need for this function, in which case it would make sense to keep it somewhere generic.
Sepehr-Sobhani
force-pushed
the
task/database-cleanup/2229
branch
2 times, most recently
from
b663aa7 to
bed6256
Compare
6 tasks
|
@andrea-williams Created this ticket for the remaining work: #3121 |
Sepehr-Sobhani
force-pushed
the
task/database-cleanup/2229
branch
from
bed6256 to
d4f36f3
Compare
…m Operation model
…cols from Operation & Operator; removed is_new from Operator
Signed-off-by: SeSo <[email protected]>
Sepehr-Sobhani
force-pushed
the
task/database-cleanup/2229
branch
from
d4f36f3 to
7ab42df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Card: #2229
Operation model:
opt_infield (leftover from Reg1; no longer needed now that we store registration purpose)operation_has_multiple_operatorsfield from database (is now inferred based on length ofmultiple_operatorsarray)verified_byandverified_atfieldsOperator model:
verified_byandverified_atfieldsis_newboolean field - no longer needed because we internal users no longer need to explicitly approve the creation of new operatorsRemaining work:
statuscolumn fromOperatormodel once we have decision on what to do with existing operators that have a status of "Draft" or "Pending" in prod