422 lfo conditions small medium

[gdalcengio]

522

Changes in this commit:

• Adding facility type through multiple props and the getFacilityDetails() function to check for Small or Medium facilities
• Activities for Small/Medium facilities have dynamically added 'Not Applicable'
• Production data page for Small/Medium facilities now have:
  • Deselect all button
  • 'Not Applicable' methodology dynamically added to each product
  • The ability to continue w/o a product while Large and Single facilities now NEED a product and disable save buttons without it
• Allocation of Emissions page for Small/Medium facilities now has a new refactored table of ReportEmissionAllocation to handle if there is no product
  • Note: this is since methodology is pulled from products which only Small/Medium facilities may not have now, so we bring the methodology to the parent table

[pbastia]

Great work! I think there's a few changes we can make to simplify the data model, and remove some frontend changes.
The button to deselect products can probably be moved to another PR or piece of work since it's not part of the AC here, and not in the UX wireframes. I think the wording was ambiguous with "Allow to deselect", which people can already do by clicking the products

[pbastia]

Creating this model breaks our database normalization rules (2NF; https://en.wikipedia.org/wiki/Database_normalization#Satisfying_2NF if you're interested in DB design) by having redundant fields on both report_emission_allocation_no_product and report_product_emission_allocation.

I think what we want to refactor here is to have

• one parent model ReportEmissionAllocation, containing the methodology, the details, and the fkey to facility_report
• optional child models ReportEmissionAllocationProduct with an FKEY to ReportEmissionAllocation containing the allocation data

[pbastia]

The refactor as suggested will make schemas easier too