Add Environment Variables - Various improvements. #1518
Conversation
LouisThedroux
added
Early Feedback Welcome
|
Openshift URLs for the PR Deployment: |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1518 +/- ##
==========================================
- Coverage 47.57% 47.40% -0.18%
==========================================
Files 926 942 +16
Lines 24182 24225 +43
Branches 3609 3619 +10
==========================================
- Hits 11505 11483 -22
- Misses 12043 12105 +62
- Partials 634 637 +3 ☔ View full report in Codecov by Sentry. |
|
Let wait for @mauberti-bc to have a look at this first. Maybe he is not happy with the idea of it and no point reviewing code thats not going to be used |
|
|
||
| // This function is a repeat of a function in another file for pluralising. It should be edited to an imported function. GridColumnDefinitionsUtils.tsx when PR goes through | ||
| const getFormattedUnit = (unit: string) => { | ||
| const unitSuffix = unit.endsWith('er') ? 's' : ''; |
There was a problem hiding this comment.
I think this is the second time we've seen this logic. I would suggest making it a standalone function.
I would add a new function next to the pluralize function in .../utils/Utils.tsx since it tackles a similar kind of issue.
Links to Jira Tickets
NA
Description of Changes
Regarding the Add Environment Variables section of the Configure Columns dialogue box on the Manage Observations page.