Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab autocompletion of yinputline shows misleading results #297

Open
Code7R opened this issue Sep 16, 2018 · 1 comment
Open

Tab autocompletion of yinputline shows misleading results #297

Code7R opened this issue Sep 16, 2018 · 1 comment
Milestone
1.4.4

Comments

@Code7R
Copy link
Collaborator

Code7R commented Sep 16, 2018

The current behavior of autocompletion action is weird. On success, it display the input as marked. On multiple option, it does the same. On failure, it does not indicate anything.

I have a vague idea on how to make it better.

a) rewrite globit.c in true C++ to get rid of the GOTO hell, and to collect output of multiple glob() rounds

b) indicate error as color change of the input line. Maybe red background? Or red font? Anyone having good arguments?

c) indicate multiple options by displaying them behind the cursor, with darker font (or lighter? Or just an average color, mean value of background and font?), maybe highlighting the first deviating letter after the length of entered prefix string with some color. Orange?
@Code7R Code7R added this to the 1.4.4 milestone Sep 16, 2018
Code7R added a commit that referenced this issue Sep 29, 2018
@Code7R
Preparations to extract possible completions from globit code
eeddcf2 
For #297
Code7R added a commit that referenced this issue Sep 30, 2018
@Code7R
Keep the text marking to visualize the final match
5243d44 
And some related refactoring, less nesting and pointless value passing.
Also not interpreting directories as final match.

Addressing part of #297, a proposal displaying solution is yet to come.
@gijsbers
Copy link
Collaborator

b) Maybe draw in inverse colors for half a second?
c) Maybe a choice of possible deviating letters like tint|<Tab> -> tint|[23],
where the choice [23] is selected and overwritten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.4
Development

No branches or pull requests
2 participants
@gijsbers @Code7R