Keep the text marking to visualize the final match

And some related refactoring, less nesting and pointless value passing.
Also not interpreting directories as final match.

Addressing part of #297, a proposal displaying solution is yet to come.

src/aaddressbar.cc

@@ -36,12 +36,12 @@ bool AddressBar::handleKey(const XKeyEvent &key) {
         else if (k == XK_Up ||
                 (k == XK_KP_Up && !(key.state & xapp->NumLockMask)))
         {
-            return changeLocation(location - 1);
+            return changeLocation(location - 1), true;
         }
         else if (k == XK_Down ||
                 (k == XK_KP_Down && !(key.state & xapp->NumLockMask)))
         {
-            return changeLocation(location + 1);
+            return changeLocation(location + 1), true;
         }
     }
     return YInputLine::handleKey(key);
@@ -80,17 +80,11 @@ bool AddressBar::handleReturn(int mask) {
     return true;
 }
 
-bool AddressBar::changeLocation(int newLocation) {
-    if (inrange(newLocation, 0, history.getCount())) {
-        location = newLocation;
-        if (location == history.getCount()) {
-            setText(null);
-        }
-        else {
-            setText(history[location]);
-        }
-    }
-    return true;
+void AddressBar::changeLocation(int newLocation) {
+    if (! inrange(newLocation, 0, history.getCount()))
+        return;
+    location = newLocation;
+    setText(location == history.getCount() ? null : history[location], true);
 }
 
 void AddressBar::showNow() {

src/aaddressbar.h

@@ -17,7 +17,7 @@ class AddressBar: public YInputLine {
     void hideNow();
 
 private:
-    bool changeLocation(int newLocation);
+    void changeLocation(int newLocation);
     bool handleReturn(int mask);
 
     IApp *app;

src/yinput.cc

@@ -53,11 +53,11 @@ YInputLine::YInputLine(YWindow *parent):
 YInputLine::~YInputLine() {
 }
 
-void YInputLine::setText(const ustring &text) {
+void YInputLine::setText(const ustring &text, bool asMarked) {
     fText = text;
     leftOfs = 0;
     curPos = fText.length();
-    markPos = curPos;
+    markPos = asMarked ? 0 : curPos;
     limit();
     repaint();
 }
@@ -680,10 +680,12 @@ void YInputLine::autoScroll(int delta, const XMotionEvent *motion) {
 
 void YInputLine::complete() {
     char* res = 0;
-    if (1 <= globit_best(cstring(fText), &res, 0, 0))
-        setText(res);
-    // FIXME: even for max. prefix the text gets marked like for a full match;
-    // that might be intended or might be a bug in limit() or paint()
+    int res_count = globit_best(cstring(fText), &res, 0, 0);
+    // directory is not a final match
+    if(res_count == 1 && upath(res).dirExists())
+        res_count++;
+    if (1 <= res_count)
+        setText(res, res_count == 1);
     free(res);
 }
 

src/yinputline.h

@@ -13,7 +13,7 @@ class YInputLine: public YWindow, public YTimerListener, public YActionListener
     YInputLine(YWindow *parent = 0);
     virtual ~YInputLine();
 
-    void setText(const ustring &text);
+    void setText(const ustring &text, bool asMarked);
     ustring getText();
 
     virtual void paint(Graphics &g, const YRect &r);