-
Notifications
You must be signed in to change notification settings - Fork 99
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Keep the text marking to visualize the final match
And some related refactoring, less nesting and pointless value passing. Also not interpreting directories as final match. Addressing part of #297, a proposal displaying solution is yet to come.
- Loading branch information
Showing
4 changed files
with
17 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@gijsbers I know this is not perfect but is IMO sufficient as stopgap solution. And I still intend to migrate globit.c to globit.cc and make it more C++ like (i.e. make use of dtors). globit.c does not handle file modes and it does not indicate what it matched (file? directory?) and fixing this is feasible but the code would become too ugly for my taste.
If you disagree or cannot wait for it, please discuss in #297 or assign it to yourself. Thanks.