Skip to content

WS-2793 Use iOS smart banners to promote shiny new WS app - #14273

Open
emilysaffron wants to merge 3 commits into
latestfrom
WS-2793-iOS-smart-banners
Open

WS-2793 Use iOS smart banners to promote shiny new WS app #14273
emilysaffron wants to merge 3 commits into
latestfrom
WS-2793-iOS-smart-banners

Conversation

@emilysaffron

Copy link
Copy Markdown
Contributor

Resolves JIRA: https://bbc.atlassian.net/browse/WS-2793

Summary

  • Set the iTunesAppId for 6761256736 for Mundo, Hindi, Arabic and Russian

  • Allow the banner to be rendered by removing the boolean hasAppleItunesAppBanner and relying just on checking if the iTunesAppId value exists for a service

Code changes

  • List key code changes that have been made.

Testing

  1. List the steps required to test this PR.

Useful Links

Copilot AI review requested due to automatic review settings July 28, 2026 10:51
@emilysaffron emilysaffron self-assigned this Jul 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables iOS Smart App Banners for selected World Service services by configuring an iTunesAppId and simplifying the banner render gate to depend on the presence of that ID (and being on a canonical/non-AMP page).

Changes:

  • Add iTunesAppId: 6761256736 to the Mundo, Hindi, Arabic, and Russian service configs.
  • Remove hasAppleItunesAppBanner from MetadataProps and stop passing it through MetadataContainer.
  • Update renderAppleItunesApp to render based on iTunesAppId + canonicalLink + !isAmp only.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/app/lib/config/services/russian.ts Adds iTunesAppId to enable iOS banner for Russian.
src/app/lib/config/services/mundo.ts Adds iTunesAppId to enable iOS banner for Mundo.
src/app/lib/config/services/hindi.ts Adds iTunesAppId to enable iOS banner for Hindi.
src/app/lib/config/services/arabic.ts Adds iTunesAppId to enable iOS banner for Arabic.
src/app/components/Metadata/utils/index.tsx Removes hasAppleItunesAppBanner from render gating logic.
src/app/components/Metadata/types.ts Removes hasAppleItunesAppBanner from MetadataProps.
src/app/components/Metadata/index.tsx Stops accepting/passing hasAppleItunesAppBanner into metadata rendering.

Comment thread src/app/components/Metadata/utils/index.tsx
Comment thread src/app/components/Metadata/types.ts
Comment thread src/app/components/Metadata/index.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants