WS-2793 Use iOS smart banners to promote shiny new WS app - #14273
Open
emilysaffron wants to merge 3 commits into
Open
WS-2793 Use iOS smart banners to promote shiny new WS app #14273emilysaffron wants to merge 3 commits into
emilysaffron wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables iOS Smart App Banners for selected World Service services by configuring an iTunesAppId and simplifying the banner render gate to depend on the presence of that ID (and being on a canonical/non-AMP page).
Changes:
- Add
iTunesAppId: 6761256736to the Mundo, Hindi, Arabic, and Russian service configs. - Remove
hasAppleItunesAppBannerfromMetadataPropsand stop passing it throughMetadataContainer. - Update
renderAppleItunesAppto render based oniTunesAppId + canonicalLink + !isAmponly.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/lib/config/services/russian.ts | Adds iTunesAppId to enable iOS banner for Russian. |
| src/app/lib/config/services/mundo.ts | Adds iTunesAppId to enable iOS banner for Mundo. |
| src/app/lib/config/services/hindi.ts | Adds iTunesAppId to enable iOS banner for Hindi. |
| src/app/lib/config/services/arabic.ts | Adds iTunesAppId to enable iOS banner for Arabic. |
| src/app/components/Metadata/utils/index.tsx | Removes hasAppleItunesAppBanner from render gating logic. |
| src/app/components/Metadata/types.ts | Removes hasAppleItunesAppBanner from MetadataProps. |
| src/app/components/Metadata/index.tsx | Stops accepting/passing hasAppleItunesAppBanner into metadata rendering. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JIRA: https://bbc.atlassian.net/browse/WS-2793
Summary
Set the iTunesAppId for 6761256736 for Mundo, Hindi, Arabic and Russian
Allow the banner to be rendered by removing the boolean hasAppleItunesAppBanner and relying just on checking if the iTunesAppId value exists for a service
Code changes
Testing
Useful Links