WS-NA: Bumps Billboard image max srcsize to from 660px to 800px - #14259
Open
Isabella-Mitchell wants to merge 3 commits into
Open
WS-NA: Bumps Billboard image max srcsize to from 660px to 800px#14259Isabella-Mitchell wants to merge 3 commits into
Isabella-Mitchell wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Billboard component’s image rendering to request a larger maximum image width so the generated srcset includes an 800w candidate, improving image quality options for high-prominence billboards.
Changes:
- Increased
BillboardimageoriginalImageWidthfrom660to800socreateSrcsetsincludes an800wentry. - Added a unit test asserting the rendered image
srcsetincludes800wfor the high-prominence variant.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/app/components/Billboard/index.tsx |
Increases the maximum image width used for srcset generation to include 800w. |
src/app/components/Billboard/index.test.tsx |
Adds coverage to confirm 800w appears in the rendered srcset for high prominence. |
Isabella-Mitchell
marked this pull request as ready for review
July 23, 2026 16:01
emilysaffron
approved these changes
Jul 24, 2026
HarveyPeachey
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JIRA: WS-NA (Stretch task of https://bbc.atlassian.net/browse/WS-2615 - will make a separate ticket if it needs one)
Alternative (simpler but less effective approach) to #14255
(Picked 800px since this is the max srcSet size provided for promo images used in Homepage curations).
Summary
Updates the Billboard component’s image rendering to request a larger maximum image width so the generated srcset includes an 800w candidate, improving image quality options for high-prominence billboards.
Noted that PS use 960px here: https://www.bbc.co.uk/news/bbcindepth (they are also using a PNG.webp and not jpeg.wepb - if that makes a difference).
Code changes
Testing
Use storybook or compare test asset, e.g. http://localhost:7081/kyrgyz?renderer_env=test and https://www.test.bbc.com/kyrgyz
See image is a teeny bit less blurry - can see 800px is the largest size in the srcSet
Useful Links