Skip to content

Commit

Permalink
translation: drop babel extractor definitions
Browse files Browse the repository at this point in the history
babel extractors are now registered via python entry points,
so there is no need to declare babel extractors in babel configs.

This change is important to make translation work in Django 2.2.
django-babel does not work with Django 2.2 and looks unmaintained
for over two years. The horizon team is thinking to switch the extractor
to enmerkar (a fork of django-babel) to make extraction of translation
string work again near future. It is important to drop the extractor
definition to make the transition smooth.

Change-Id: I3ec4561eba1387876c2bbd8ea0f227043e1809ca
  • Loading branch information
amotoki committed Dec 28, 2019
1 parent 56af6c0 commit f6b5a2d
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 15 deletions.
3 changes: 0 additions & 3 deletions babel-django.cfg
Original file line number Diff line number Diff line change
@@ -1,5 +1,2 @@
[extractors]
django = django_babel.extract:extract_django

[python: **.py]
[django: templates/**.html]
12 changes: 0 additions & 12 deletions babel-djangojs.cfg
Original file line number Diff line number Diff line change
@@ -1,14 +1,2 @@
[extractors]
# We use a custom extractor to find translatable strings in AngularJS
# templates. The extractor is included in horizon.utils for now.
# See http://babel.pocoo.org/docs/messages/#referencing-extraction-methods for
# details on how this works.
angular = horizon.utils.babel_extract_angular:extract_angular

[javascript: **.js]

# We need to look into all static folders for HTML files.
# The **/static ensures that we also search within
# /openstack_dashboard/dashboards/XYZ/static which will ensure
# that plugins are also translated.
[angular: **/static/**.html]

0 comments on commit f6b5a2d

Please sign in to comment.