https://github.com/bbc/digital-paper-edit-api/issues/1 adding diagram… #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietrop
suggested changes
Jun 25, 2019
There was a problem hiding this comment.
We are getting there
- I might have missed which of the 3 options we are going for, or whether we are still deciding?
- it's good to have an abstraction in front of PSTT via the STT Proxy service to avoid logic of PSTT to overflow into the rest of our system, and keep a healthy separation of concerns.
|
Images for option 2 and 3 might not show up?
|
Co-Authored-By: Pietro <[email protected]>
Co-Authored-By: Pietro <[email protected]>
…ucture into arch_adr
pietrop
previously requested changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s and updated ADR
Is your Pull Request request related to another issue in this repository ?
bbc/digital-paper-edit-api#1
Describe what the PR does
Updates and fills in the details of the communication between microservices.
State whether the PR is ready for review or whether it needs extra work
Ready
Additional context
We've discussed different cloud approaches, including Microsoft and AWS's best practice guidelines.
Acceptance Criteria
Definitions of Done