Better error handling

bb-io · Mar 20, 2024 · 75c0bba · 75c0bba
1 parent 8ec1070
commit 75c0bba
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Apps.Lionbridge/Actions/SupportAssetsActions.cs b/Apps.Lionbridge/Actions/SupportAssetsActions.cs
@@ -49,7 +49,7 @@ public async Task<SupportAssetResponse> AddSupportAsset([ActionParameter] GetJob
         var apiRequest = new LionbridgeRequest(endpoint, Method.Post)
             .AddJsonBody(new
             {
-                fmsFileId = uploadResponse.FmsFileId,
+                fmsFileId = uploadResponse.FmsFileId ?? throw new Exception("FMS file ID is missing"),
                 description = addSupportAssetRequest.Description,
                 sourceNativeIds = addSupportAssetRequest.SourceNativeIds ?? new List<string> { Guid.NewGuid().ToString() },
                 sourceNativeLanguageCode = addSupportAssetRequest.SourceNativeLanguageCode,

diff --git a/Apps.Lionbridge/LionbridgeInvocable.cs b/Apps.Lionbridge/LionbridgeInvocable.cs
@@ -44,7 +44,7 @@ protected async Task<UploadSourceFileResponse> UploadFmsFile(string jobId, AddFi
         string fmsMultipartUrl = response.FmsPostMultipartUrl;
 
         var fileStream = await fileManagementClient.DownloadAsync(fileRequest.File);
-        var memoryStream = new MemoryStream();
+        using var memoryStream = new MemoryStream();
         await fileStream.CopyToAsync(memoryStream);
 
         var bytes = memoryStream.ToArray();