Skip to content

Commit

Permalink
Drop use of hashbrown
Browse files Browse the repository at this point in the history
Since Rust 1.36, this is the default HashMap implementation so there is
no need to pull in an external crate.

This essentially reverts 636412f.
  • Loading branch information
jmmv committed Oct 24, 2019
1 parent d394616 commit 2dc3225
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 8 deletions.
1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ env_logger = "0.5"
failure = "~0.1.2"
fuse = "0.3"
getopts = "0.2"
hashbrown = "0.1"
log = "0.4"
nix = "0.12"
serde = "1.0"
Expand Down
4 changes: 0 additions & 4 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@

**STILL UNDER DEVELOPMENT; NOT RELEASED YET.**

* Switched to the hashbrown implementation of Swiss Tables for hash maps,
which brings an up to 1% performance improvement during Bazel builds
that use sandboxfs.

* Fixed the definition of `--input` and `--output` to require an argument,
which makes `--foo bar` and `--foo=bar` equivalent. This can be thought to
break backwards compatibility but, in reality, it does not. The previous
Expand Down
3 changes: 1 addition & 2 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
#[cfg(feature = "profiling")] extern crate cpuprofiler;
#[macro_use] extern crate failure;
extern crate fuse;
extern crate hashbrown;
#[macro_use] extern crate log;
extern crate nix;
extern crate serde_derive;
Expand All @@ -41,9 +40,9 @@ extern crate signal_hook;
extern crate time;

use failure::{Fallible, Error, ResultExt};
use hashbrown::HashMap;
use nix::errno::Errno;
use nix::{sys, unistd};
use std::collections::HashMap;
use std::ffi::OsStr;
use std::fmt;
use std::fs;
Expand Down
2 changes: 1 addition & 1 deletion src/nodes/dir.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ extern crate time;

use {Cache, create_as, IdGenerator};
use failure::{Fallible, ResultExt};
use hashbrown::HashMap;
use nix::{errno, fcntl, sys, unistd};
use nix::dir as rawdir;
use nodes::{ArcHandle, ArcNode, AttrDelta, Handle, KernelError, Node, NodeResult, conv, setattr};
use std::collections::HashMap;
use std::ffi::{OsStr, OsString};
use std::os::unix::ffi::OsStrExt;
use std::os::unix::fs::{self as unix_fs, DirBuilderExt, OpenOptionsExt};
Expand Down

0 comments on commit 2dc3225

Please sign in to comment.