-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kotlin Support / Scala Fix #418
base: master
Are you sure you want to change the base?
Conversation
This PR fixes and closes bazelbuild#407, wherein, the build breaks because it references a `rules_scala` version that accesses Maven Central via HTTP. After late Jan 2020, HTTP is no longer allowed on Maven Central, so it produces a build error for anyone who doesn't have the artifact cached already. The only change is upgrading `rules_scala` to the latest `HEAD`, which at this time is bazelbuild/rules_scala@d2e7e3b.
This changeset adds support for running tests written in Kotlin, via the same mechanism used to run Scala tests. The README is also updated with a test sample, and there is a unit test alongside `WebTestTest.java`, but written in Kotlin.
Fix: Scala HTTP Maven error (bazelbuild#408)
Update from Upstream
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Hi Sam, it looks like you haven't signed our CLA yet. We can't accept this contribution until you've signed it; please visit https://cla.developers.google.com/clas to address this. Thanks! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@mtrea who is it not finding a CLA for? |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Sorry for the difficulties, Sam. Here's what's going on:
Since you happen to be the CLA administrator for your corp CLA, you can add your alternate email addresses to the CLA group you manage. Alternatively, you can re-push the commits with the known email address (help). |
Sorry, I'm no longer actively working on this project. Please re-assign this back to @mtrea . Somehow I can't re-assign it by myself. |
See enclosed commits - fixes an issue with Scala dependencies, and introduces Kotlin support via the same route as Scala.