Add generate_internal_visibility_from_proto_files feature #962
+39
−43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #961
Change
Create a new feature
swift.generate_internal_visibility_from_proto_files
which will set protoc's swift_optVisibility
fromPublic
toInternal
.Test
swift_grpc_library
orswift_proto_library
swift.generate_internal_visibility_from_proto_files
to thefeatures
attribute for the above ruleinternal
)Note
The ideal solution would be to make the
Public
setting opt-in for this feature, thereby mirroring default protoc Swift plugin behavior. Since rules_swift has always defaulted to public visibility this should instead remain the default.