-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update remote swift debugging doc #841
base: master
Are you sure you want to change the base?
Conversation
As far as I can tell at this point the local debugging options enabled module is no longer required at least with Swift 5.6+, as long as you correctly set the framework search paths to include the directories containing XCTest.
Lyft integration job started: https://buildkite.com/lyft/rules-swift/builds/408 (must be Lyft employee to view) |
I've seen otherwise. I was going to have to set lots of LLDB settings, and it wouldn't fully cover every situation that I'll test again next week and report some detailed findings here. Maybe I was holding it wrong. |
Yea I'd love to see any case you can come up with. I dropped this internally and it seems to work in my testing. Although it's a bit sketchy sometimes because I found I had to kill lldb-rpc-server sometimes to invalidate it's cache |
I re-read your changes. They are technically correct, since setting |
If I understand that conversation correctly I don't think we're really solving that in the original solution or this new solution as we still recommend you disable that globally, so if there isn't 1 set of flags that works for you (that are also the ones passed to the local debug options module), it wouldn't work either way since you're dropping these for all the others regardless? So you could just set the one set of flags that would otherwise apply to your single local module to the lldb setting? I think the real solution in general is #842 but I don't have time to investigate that at the moment |
bump, am i missing a case with this? |
@brentleyjones bump |
It does require more than you state in the PR description, when dealing with Objective-C dependencies. And But, since rules_xcodeproj now solves this for any use case I'm going to recommend, I'm fine with removing that portion 🤷♂️. |
As far as I can tell at this point the local debugging options enabled
module is no longer required at least with Swift 5.6+, as long as you
correctly set the framework search paths to include the directories
containing XCTest.