Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a runfiles library #1310

Draft
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

cerisier
Copy link

@cerisier cerisier commented Sep 17, 2024

First shot at implementing #890

Main implementation

I followed guidance from @fmeum and based this implementation on the runfiles library of rules_python where applicable since this was pointed as the reference implementation.

The non applicable parts, especially the runtime computation of the runfiles directory has been inspired by the implementation in rules_rust.

TODO

  • Implement runfiles directory detection from argv0
  • Make a proper PR description describing the API, the heuristics behind directory discovery and path lookup.
  • Discuss the proper way to solve the current repository issue and whether to keep the BazelRunfilesConstants file generation.
  • Fix Linux compat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants