[WIP] Handle a unused_dependency_checker_ignored_targets #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ittaiz I suspect this is an issue with the high-level mode, because looking the source I don't see references to xml. And it seems this does work with ast mode. So once we switch transitive to use ast instead of high-level by default (and change the tests to all use ast instead of high-level), this should be solved. |
|
SGTM, |
|
I added a mention in the first post of #867 (which contains the other TODOs as well), is that sufficient? |
|
Indeed. Can we close this PR for now? |
gergelyfabian
pushed a commit
to gergelyfabian/rules_scala
that referenced
this pull request
May 31, 2022
* Use default table style * Remove redundant classfile version * Repeat and shorten cells to archieve visual grid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP, just here for the CI
Motivation
WIP