Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bzlmod examples on windows #2454

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Fix bzlmod examples on windows #2454

merged 2 commits into from
Feb 23, 2024

Commits on Feb 23, 2024

  1. Fix bzlmod on windows 

    On windows (and some other platforms), the file extension of cargo, rustc, etc have an extension. The module extension for loading crates did not take this into account, causing it to error on windows.

Additionally, when using bzlmod to build vendored crates, the runfiles tree would exceed the 260 char windows path limit. To mitigate this, I have shortened the internal_deps module extension to just i and changed the build script suffix to `_bs`, from `_build_script`. This makes the path names below the 260 char limit.

This makes the bzlmod CI run on windows, to avoid regressing this. Currently gen_rust_project does not run on windows for other reasons, although we do build this.
    @cameron-martin
    cameron-martin committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    b0d5b83 View commit details
    Browse the repository at this point in the history

  2. Revendor crates

    @cameron-martin
    cameron-martin committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    43662a9 View commit details
    Browse the repository at this point in the history