Adjust is_exec_configuration heuristic #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of looking for "-exec-" look for "-exec" since that portion may be the last component of the output path mneumonic. Ultimately fixes issues with --experimental_platforms_in_output_dir that had sufficiently improved calculations to remove the need for an ST-hash and thus surfaced this issue. Ideally, in the long term, this heuristic would not be used and whether an artifact is in the exec configuration would be determined by tracking the provenance of that artifact. However, this would likely require a more significant rework.
illicitonion
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of looking for "-exec-" look for "-exec" since that portion may be the last component of the output path mneumonic.
Ultimately fixes issues with --experimental_platforms_in_output_dir that had sufficiently improved calculations to remove the need for an ST-hash and thus surfaced this issue.
Ideally, in the long term, this heuristic would not be used and whether an artifact is in the exec configuration would be determined by tracking the provenance of that artifact. However, this would likely require a more significant rework.