[prost] Fix handling of message names with acronyms #2193
Merged
+63
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, the message name `SomeAPI`. Internally protoc-gen-prost [converts](https://github.com/neoeinstein/protoc-gen-prost/blob/1a6d3593622af18b75a4a79f545f8530cdaf444f/protoc-gen-tonic/src/util.rs#L14) this to upper camel case, but rules_rust is not doing that when populating the `--extern_path` args. The result is that when a message with an acroynym in its name is included in another proto file, the generated code has a type name with the wrong casing. Without this fix, the added test fails to build like this: ``` error[E0412]: cannot find type `NameWithCAPS` in module `camel_case_proto::camel_case` --> bazel-out/k8-fastbuild/bin/proto/prost/private/tests/camel_case/another_proto.lib.rs:9:75 | 9 | pub inner: ::core::option::Option<::camel_case_proto::camel_case::NameWithCAPS>, | ^^^^^^^^^^^^ help: a struct with a similar name exists: `NameWithCaps` --> bazel-out/k8-fastbuild/bin/proto/prost/private/tests/camel_case/camel_case_proto.lib.rs:7:5 | = note: similarly named struct `NameWithCaps` defined here error: aborting due to previous error ```
william-smith-skydio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, the message name
SomeAPI. Internally protoc-gen-prost converts this to upper camel case, but rules_rust is not doing that when populating the--extern_pathargs. The result is that when a message with an acroynym in its name is included in another proto file, the generated code has a type name with the wrong casing.Without this fix, the added test fails to build like this: