Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Flip experimental_use_coverage_metadata_files" #2164

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Revert "Flip experimental_use_coverage_metadata_files" #2164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b3b1cb
Revert "Flip experimental_use_coverage_metadata_files (#2128)"
UebelAndre Sep 20, 2023
8e77865
Merge branch 'main' into revert-2128-coverage
UebelAndre Sep 21, 2023
1ab6c1f
Merge branch 'main' into revert-2128-coverage
UebelAndre Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .bazelci/presubmit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,9 +223,6 @@ tasks:
# If updating the minimum bazel version, please also update /docs/index.md
bazel: "6.3.0"
platform: ubuntu1804
# Disable use of `instrumented_files_info.metadata_files` until Bazel 6.3 is the min version
shell_commands:
- echo 'build --//rust/settings:experimental_use_coverage_metadata_files=false' > user.bazelrc
build_targets: *default_linux_targets
test_targets: *default_linux_targets
coverage_targets: *default_linux_targets
Expand All @@ -234,9 +231,6 @@ tasks:
name: "Min Bazel Version With Aspects"
bazel: "6.3.0"
platform: ubuntu1804
# Disable use of `instrumented_files_info.metadata_files` until Bazel 6.3 is the min version
shell_commands:
- echo 'build --//rust/settings:experimental_use_coverage_metadata_files=false' > user.bazelrc
build_targets: *default_linux_targets
test_targets: *default_linux_targets
build_flags: *aspects_flags
Expand Down
2 changes: 1 addition & 1 deletion rust/settings/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ bool_flag(
# reporting tools like `llvm-cov` and `llvm-profdata` as runfiles to each test.
bool_flag(
name = "experimental_use_coverage_metadata_files",
build_setting_default = True,
build_setting_default = False,
)

bzl_library(
Expand Down
Loading