Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for UEFI targets and OS #2142

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for UEFI targets and OS #2142

wants to merge 1 commit into from

Conversation

lorenz
Copy link

@lorenz lorenz commented Aug 29, 2023

UebelAndre
UebelAndre approved these changes Mar 31, 2024
View reviewed changes
Copy link
Collaborator

@UebelAndre UebelAndre left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine for whenever the upstream PR merges 😄

Thank you!

@amari amari mentioned this pull request Jul 13, 2024
Merged
@amari
Copy link
Contributor

amari commented Jul 13, 2024 •
edited
Loading

I've opened a new upstream PR (bazelbuild/platforms#97) since the original one seems to be abandoned.

@lorenz
Copy link
Author

lorenz commented Jul 13, 2024 •
edited
Loading

That PR is not really abandoned, it has approval and is waiting for someone on the Bazel team to merge it (I'm the person who did both PRs).

@amari amari mentioned this pull request Jul 16, 2024
Closed
@lorenz
Copy link
Author

lorenz commented Jul 25, 2024

I'll rebase this either this week or early next one, then we can merge it now that the platform constraint has been merged upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UebelAndre UebelAndre UebelAndre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lorenz @amari @UebelAndre