Skip to content

Commit

Permalink
Remove unnecessary eval to fix PATH variables containing a space (#2087)
Browse files Browse the repository at this point in the history
Fixes #2086

As far as I can tell, this `eval` is unnecessary at best, and breaks
with certain edge cases, like `PATH` (or other referenced variables)
which include a space.

I'm not very familiar with this repo, but if there's a way to add a test
for this I'd be happy to do it.

Co-authored-by: UebelAndre <[email protected]>
  • Loading branch information
belak and UebelAndre authored Jul 28, 2023
1 parent ddbce7e commit 7e67ce9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion crate_universe/private/crates_vendor.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ fi
# If you provide an empty path, bazel starts itself with
# --default_system_javabase set to the empty string, but if you provide a path,
# it may set it to a value (eg. "/usr/local/buildtools/java/jdk11").
eval exec env - BAZEL_REAL="${{BAZEL_REAL}}" BUILD_WORKSPACE_DIRECTORY="${{BUILD_WORKSPACE_DIRECTORY}}" PATH="${{PATH}}" {env} \\
exec env - BAZEL_REAL="${{BAZEL_REAL}}" BUILD_WORKSPACE_DIRECTORY="${{BUILD_WORKSPACE_DIRECTORY}}" PATH="${{PATH}}" {env} \\
"{bin}" {args} "$@"
"""

Expand Down

0 comments on commit 7e67ce9

Please sign in to comment.