Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sphinxdocs): allow using sphinx_stardoc with bzlmod #2295

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(sphinxdocs): allow using sphinx_stardoc with bzlmod #2295

wants to merge 1 commit into from

Commits on Oct 11, 2024

  1. fix(sphinxdocs): allow using sphinx_stardoc with bzlmod 

    Using the sphinx_stardoc rule doesn't work with bzlmod because it
refers to the stardoc repo, which was a dev dependency. This means,
even if a user's root module has visibility to stardoc, rules_python
doesn't.

To fix, make stardoc a non-dev dependency. With bzlmod semantics,
stardoc won't actually be loaded unless a user depends on it by
using sphinxdocs.
    @rickeylev
    rickeylev committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    667ed13 View commit details
    Browse the repository at this point in the history