fix: pass kwargs env to both update and test targets
#2277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me. If it's not too much a hassle, it'd be good to write an automated test for this to avoid future breakage. |
aignas
reviewed
Oct 8, 2024
Done! |
lpulley
force-pushed
the
fix-pip-compile-py-binary-env
branch
from
5d26d19
to
6c29c8a
Compare
cj81499
reviewed
Oct 8, 2024
|
|
||
| py_binary( | ||
| name = name + ".update", | ||
| env = env, |
There was a problem hiding this comment.
I'm surprised that we need the fake USERPROFILE only for _test and not for .update too.
Why is that the case?
There was a problem hiding this comment.
Well... X_test runs as a Bazel action. X.update is only expected to be invoked by the user directly, in a normal environment.
There was a problem hiding this comment.
Seems like a possible source of confusion to have different behavior here, but I trust your (and @aignas's) judgement on this.
lpulley
force-pushed
the
fix-pip-compile-py-binary-env
branch
from
6c29c8a
to
f66e55a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2270.