Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf tests to use forked Closure test suite #636

Merged
merged 12 commits into from
Jan 7, 2025
Merged
1 change: 1 addition & 0 deletions .bazelversion
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
7.4.1
6 changes: 6 additions & 0 deletions MODULE.bazel
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
###############################################################################
# Bazel now uses Bzlmod by default to manage external dependencies.
# Please consider migrating your external dependencies from WORKSPACE to MODULE.bazel.
#
# For more details, please check https://github.com/bazelbuild/bazel/issues/18958
###############################################################################
6 changes: 3 additions & 3 deletions closure/protobuf/test/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ closure_js_test(
],
deps = [
":foo",
"@com_google_javascript_closure_library//closure/goog/testing:testsuite",
"//closure/testing/library:testsuite",
],
)

Expand Down Expand Up @@ -95,7 +95,7 @@ closure_js_test(
deps = [
":baz",
":foo",
"@com_google_javascript_closure_library//closure/goog/testing:testsuite",
"//closure/testing/library:testsuite",
],
)

Expand Down Expand Up @@ -131,6 +131,6 @@ closure_js_test(
],
deps = [
":bat",
"@com_google_javascript_closure_library//closure/goog/testing:testsuite",
"//closure/testing/library:testsuite",
],
)
4 changes: 2 additions & 2 deletions closure/protobuf/test/legacy/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ closure_js_test(
srcs = ["example_test.js"],
deps = [
":example_lib",
"@com_google_javascript_closure_library//closure/goog/testing:asserts",
"@com_google_javascript_closure_library//closure/goog/testing:jsunit",
"//closure/testing/library:asserts",
"//closure/testing/library:jsunit",
],
)
2 changes: 1 addition & 1 deletion closure/protobuf/test/legacy/example_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ goog.require('io.bazel.rules.closure.protobuf.Example');
function testExample() {
var msg = new io.bazel.rules.closure.protobuf.Example('value');
msg.field();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be dropped

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that this whole test should be dropped?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the line; it doesn't do anything.

assertHTMLEquals('value', msg.field());
assertEquals('value', msg.field());
}