Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf tests to use forked Closure test suite #636

Merged
merged 12 commits into from
Jan 7, 2025
Merged

Update protobuf tests to use forked Closure test suite #636

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
83b25d4
Update protobuf test to use jssuite from forked files
mollyibot Dec 28, 2024
db621a3
Update bazel version
mollyibot Dec 28, 2024
de3b0d5
Update protobuf test to use jssuite from forked files
mollyibot Jan 2, 2025
bf0b21c
Update protobuf test to use jssuite from forked files and remove usag…
mollyibot Jan 2, 2025
9a8548e
Remove legacy protobuf test
mollyibot Jan 7, 2025
a15a84a
Add back legacy test
mollyibot Jan 7, 2025
a448728
Add a blank line at the end of legacy example test
mollyibot Jan 7, 2025
23cf737
Update legacy test to use forked jsunit and asserts
mollyibot Jan 7, 2025
6e8ca83
Update legacy test to use forked jsunit and asserts
mollyibot Jan 7, 2025
04e467a
Add back require line and remove additional msg.field()
mollyibot Jan 7, 2025
8a6afb9
Merge branch 'bazelbuild:master' into master
mollyibot Jan 7, 2025
8003246
Merge branch 'master' into master
mollyibot Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions closure/protobuf/test/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ closure_js_test(
],
deps = [
":foo",
"@com_google_javascript_closure_library//closure/goog/testing:testsuite",
"//closure/testing/library:testsuite",
],
)

Expand Down Expand Up @@ -95,7 +95,7 @@ closure_js_test(
deps = [
":baz",
":foo",
"@com_google_javascript_closure_library//closure/goog/testing:testsuite",
"//closure/testing/library:testsuite",
],
)

Expand Down Expand Up @@ -131,6 +131,6 @@ closure_js_test(
],
deps = [
":bat",
"@com_google_javascript_closure_library//closure/goog/testing:testsuite",
"//closure/testing/library:testsuite",
],
)
4 changes: 2 additions & 2 deletions closure/protobuf/test/legacy/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ closure_js_test(
srcs = ["example_test.js"],
deps = [
":example_lib",
"@com_google_javascript_closure_library//closure/goog/testing:asserts",
"@com_google_javascript_closure_library//closure/goog/testing:jsunit",
"//closure/testing/library:asserts",
"//closure/testing/library:jsunit",
],
)
3 changes: 1 addition & 2 deletions closure/protobuf/test/legacy/example_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,10 @@

goog.require('goog.testing.asserts');
goog.require('goog.testing.jsunit');
goog.require('io.bazel.rules.closure.protobuf.Example');
mollyibot marked this conversation as resolved.
Show resolved Hide resolved


function testExample() {
var msg = new io.bazel.rules.closure.protobuf.Example('value');
msg.field();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be dropped

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that this whole test should be dropped?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the line; it doesn't do anything.

assertHTMLEquals('value', msg.field());
assertEquals('value', msg.field());
}