Use buildifier 6.4.0 for improved load sorting #2500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikkerber
force-pushed
the
ek/buildifier-6.4.0
branch
from
536ef3d
to
160904b
Compare
erikkerber
force-pushed
the
ek/buildifier-6.4.0
branch
from
160904b
to
15fe4a8
Compare
erikkerber
requested review from
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
luispadron
approved these changes
Jul 12, 2024
brentleyjones
approved these changes
Jul 12, 2024
sewerynplazuk
pushed a commit
to sewerynplazuk/rules_apple
that referenced
this pull request
Sep 20, 2024
Followup to/depends on bazelbuild#2499 Bigger PR than 2499 due to me not including `.bzl` files. I was using a command from my history that just operated on BUILD/MODULE files. Big enough it might make upstream merges a little painful? I'll leave that thought to the maintainers. **6.3.3:** `out_of_order_load` warning is enabled by default **6.4.0:** More correct sorting order of load statements Could bump to 7.1.2 which is latest, but not necessary for auto fixing of load sorting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to/depends on #2499
Bigger PR than 2499 due to me not including
.bzlfiles. I was using a command from my history that just operated on BUILD/MODULE files. Big enough it might make upstream merges a little painful? I'll leave that thought to the maintainers.6.3.3:
out_of_order_loadwarning is enabled by default6.4.0: More correct sorting order of load statements
Could bump to 7.1.2 which is latest, but not necessary for auto fixing of load sorting