Remove explicit repo name loading local bzl files #2485
Conversation
erikkerber
force-pushed
the
master
branch
3 times, most recently
from
299e557
to
7de57c6
Compare
| load("//apple/internal:providers.bzl", "new_appleplatforminfo") | ||
| load("//apple:providers.bzl", "ApplePlatformInfo") | ||
| load("@bazel_tools//tools/cpp:toolchain_utils.bzl", "find_cpp_toolchain", "use_cpp_toolchain") |
There was a problem hiding this comment.
After doing this, can you reorder the loads? Relative ones should be below external ones.
There was a problem hiding this comment.
Related: I noticed buildifier isn't run on PR's here. By design or should that be added?
There was a problem hiding this comment.
It's checked in buildkite/rules-apple-darwin/pr/buildifier, right?
There was a problem hiding this comment.
(Though maybe it's not as strict as it should be.)
There was a problem hiding this comment.
Ran buildifier on the repo locally/manually and got this diff and others like it. I'll look to see if it's a version diff or something.
There was a problem hiding this comment.
I'll make the sorts another PR, and if I see a buildifier fix I'll include that with it.
erikkerber
force-pushed
the
master
branch
2 times, most recently
from
c2fd7e3
to
91d355a
Compare
erikkerber
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
|
|
Followup request from #2485 rules_apple is on buildifier 6.3.2, one version before load sorting improvements. Can update that too.
Removes explicit repo names in load commands in favor of relative names.