Update ios_ui_test section to have test_host to be required #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ios_ui_test needs` a test_host as part of a required parameter. The docs mention it as optional however it is a required param https://github.com/bazel-ios/rules_ios/blob/master/rules/test.bzl#L273
ssarad
requested review from
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
luispadron
reviewed
Jun 20, 2024
| @@ -598,7 +598,7 @@ of the attributes inherited by all test rules, please check the | |||
| | <a id="ios_ui_test-runner"></a>runner | The runner target that will provide the logic on how to run the tests. Needs to provide the AppleTestRunnerInfo provider. | <a href="https://bazel.build/concepts/labels">Label</a> | required | | | |||
| | <a id="ios_ui_test-test_coverage_manifest"></a>test_coverage_manifest | A file that will be used in lcov export calls to limit the scope of files instrumented with coverage. | <a href="https://bazel.build/concepts/labels">Label</a> | optional | `None` | | |||
| | <a id="ios_ui_test-test_filter"></a>test_filter | Test filter string that will be passed into the test runner to select which tests will run. | String | optional | `""` | | |||
| | <a id="ios_ui_test-test_host"></a>test_host | - | <a href="https://bazel.build/concepts/labels">Label</a> | optional | `None` | | |||
| | <a id="ios_ui_test-test_host"></a>test_host | - | <a href="https://bazel.build/concepts/labels">Label</a> | required | `None` | | |||
There was a problem hiding this comment.
We'd have to update the rule attr as well which I believe is shared with the other iOS test rules.
Maybe we could override this attr in the ui test rule so it can have its own documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ios_ui_testneeds a test_host as part of a required parameter. The docs mention it as optional however it is a required paramhttps://github.com/bazel-ios/rules_ios/blob/master/rules/test.bzl#L273