Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix app intents with Xcode 15.3+ #2418

Merged
merged 7 commits into from
Jul 10, 2024
Merged

Fix app intents with Xcode 15.3+ #2418

merged 7 commits into from
Jul 10, 2024

Commits on Jul 9, 2024

  1. Have Xcode 15+ builds support the newer App Intents metadata processo… 

    …r logic.

PiperOrigin-RevId: 589151949
(cherry picked from commit 41d5bb7)
    @nglevin @luispadron
    nglevin authored and luispadron committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    16cb877 View commit details
    Browse the repository at this point in the history

  2. Fix to resolve error when compiling app intents indicating that it ex… 

    …pects all values to be statically allocated and resolved at compile time.

This pulls all of the module names found from SwiftInfo when gathering the swiftconstfiles. This appears to work in the test targets set up, which do lean on the multiple module strategy.

PiperOrigin-RevId: 589938532
(cherry picked from commit 5668eb4)
    @nglevin @luispadron
    nglevin authored and luispadron committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    d9451cd View commit details
    Browse the repository at this point in the history

  3. Only allow one module to define App Intents, as that is all that Appl… 

    …e's app intents metadata processor tool allows for.

PiperOrigin-RevId: 590322476
(cherry picked from commit 21b435b)
    @nglevin @luispadron
    nglevin authored and luispadron committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    6301a19 View commit details
    Browse the repository at this point in the history

  4. Append the Xcode build version to the appintentsmetadataprocessor for… 

    … Xcode 15.3 builds, based on the version string reported from the XcodeVersionConfig provider.

PiperOrigin-RevId: 601786735
(cherry picked from commit ea240b8)
    @nglevin @luispadron
    nglevin authored and luispadron committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    c51f19c View commit details
    Browse the repository at this point in the history

  5. Compat

    @keith @luispadron
    keith authored and luispadron committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    e84f076 View commit details
    Browse the repository at this point in the history

  6. Possible fix for breaking change

    @BalestraPatrick @luispadron
    BalestraPatrick authored and luispadron committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    2221ba3 View commit details
    Browse the repository at this point in the history

  7. Update for rules_swift 2.0.0

    @luispadron
    luispadron committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    ea520cd View commit details
    Browse the repository at this point in the history