Alternate asset catalog icon #2291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendyliga
requested review from
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob,
segiddins and
thii
as code owners
|
Can you rebase on |
|
Do we want to take this upstream commit 6fc1952 ? |
if that commit works, i think we can use that one instead |
|
Hello, I see that there has been no progress on this issue for a long time. Probably We could use the commit of 6fc1952 to solve this problem？But I don't see any CI check on this commit. Is the solution of this commit stable? |
|
@Hydralisk2333 were working on upstreaming some more commits now to the rules, it will take some time though. If you want to PR and attempt the cherry pick we can review it |
|
Is this change still required? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes try to fix this issue #1261