Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix action_env for ipa post processor #2232

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MIP9
Copy link

@MIP9 MIP9 commented Sep 4, 2023

Environment variables that provided by --action_env flag are not accessible on ipa_post_processor .sh script.

There is fix for it.

@google-cla
Copy link

google-cla bot commented Sep 4, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@thii
Copy link
Member

thii commented Sep 5, 2023

@MIP9 Can you sign the CLA?

@thii
Copy link
Member

thii commented Sep 5, 2023

Can you rebase off master? Looks like buildifier is reporting outdated warnings from an old revision.

Other CI issues are probably related to the current GitHub's incident.

@MIP9 MIP9 force-pushed the bugfix/ipa_post_processor_env branch from c4b6636 to f3fe5b3 Compare September 5, 2023 15:54
@MIP9 MIP9 force-pushed the bugfix/ipa_post_processor_env branch from f3fe5b3 to 31c218f Compare September 5, 2023 16:05
@keith
Copy link
Member

keith commented Sep 5, 2023

this is also being fixed in bazel with bazelbuild/bazel#18235

@acecilia
Copy link

acecilia commented Sep 5, 2023

@keith Does this PR still make sense? Or do you think better leave as is and wait for bazel 6.4.0?

@keith
Copy link
Member

keith commented Sep 5, 2023

yea that's a good question, can you test with 6.4 and see if it really does fix it?

@acecilia
Copy link

acecilia commented Sep 5, 2023

Seems the cherrypick did not make it to 6.4.0 yet, and the commit has not been built with bazel ci (so there is no prebuilt bazel binary), so I am not sure how to test it atm 😅

@thii
Copy link
Member

thii commented Sep 6, 2023

If you use bazelisk you can set last_green as a version and try that.

@thii
Copy link
Member

thii commented Sep 6, 2023

Or build a bazel binary with that patch.

@keith
Copy link
Member

keith commented Sep 20, 2023

note that with bazel 7.x HEAD of rules_apple now enables that env for all actions (or tries too, possible I missed some)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants