Add/omit the HeadersPath Info.plist key for XCFramework with static libraries. #2115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibraries. An XCFramework with static libraries can include public Objective-C(++) headers using the `public_hdrs` rule attribute, or generated headers from the underlying Swift module. This change updates the XCFramework Info.plist generation logic to add or omit the `HeadersPath` key if there are any header files. PiperOrigin-RevId: 499574821 (cherry picked from commit e00404a)
|
the actual change here wasn't relevant because we produce frameworks not libraries for this rule, so I'm not sure if we'll take these tests or not |
keith
referenced
this pull request
Aug 18, 2023
…ibraries. An XCFramework with static libraries can include public Objective-C(++) headers using the `public_hdrs` rule attribute, or generated headers from the underlying Swift module. This change updates the XCFramework Info.plist generation logic to add or omit the `HeadersPath` key if there are any header files. PiperOrigin-RevId: 499574821
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An XCFramework with static libraries can include public
Objective-C(++) headers using the
public_hdrsrule attribute,or generated headers from the underlying Swift module.
This change updates the XCFramework Info.plist generation logic
to add or omit the
HeadersPathkey if there are any header files.PiperOrigin-RevId: 499574821
(cherry picked from commit e00404a)