Add the apple.no_legacy_swiftinterface feature to disable the automatic library evolution transition on framework rules.
#2104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs this in rules_swift bazelbuild/rules_swift@b9175e6 |
keith
referenced
this pull request
Aug 18, 2023
…atic library evolution transition on framework rules. We are migrating users to a model where a new attribute, `library_evolution`, must be set on `swift_library` targets that vend the user-facing module in a framework, instead of automatically applying library evolution to the whole subgraph. In order to migrate, users can add this feature to their framework target and at the same time set `library_evolution = True` on their library. Once everyone is migrated, library evolution should be removed entirely from the Apple transitions and the feature can be removed from BUILD files. PiperOrigin-RevId: 487022298
…atic library evolution transition on framework rules. We are migrating users to a model where a new attribute, `library_evolution`, must be set on `swift_library` targets that vend the user-facing module in a framework, instead of automatically applying library evolution to the whole subgraph. In order to migrate, users can add this feature to their framework target and at the same time set `library_evolution = True` on their library. Once everyone is migrated, library evolution should be removed entirely from the Apple transitions and the feature can be removed from BUILD files. PiperOrigin-RevId: 487022298 (cherry picked from commit cb9a1de)
keith
force-pushed
the
ks/add-the-apple.no_legacy_swiftinterface-feature-to-disable-the-automatic-library-evolution-transition-on-framework-rules
branch
from
8bdaeaf
to
cc56d80
Compare
PiperOrigin-RevId: 559113679 (cherry picked from commit b5c71a6)
|
We need to land this in order to land #2401. |
|
feel free to take this one over, i don't recall the state |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are migrating users to a model where a new attribute,
library_evolution, must be set onswift_librarytargets that vend the user-facing module in a framework, instead of automatically applying library evolution to the whole subgraph. In order to migrate, users can add this feature to their framework target and at the same time setlibrary_evolution = Trueon their library.Once everyone is migrated, library evolution should be removed entirely from the Apple transitions and the feature can be removed from BUILD files.
PiperOrigin-RevId: 487022298
(cherry picked from commit cb9a1de)