Allow underscores in bundle identifiers (#2411)

bazelbuild · Feb 24, 2024 · 6a3a36e · 6a3a36e
1 parent fdb07d0
commit 6a3a36e
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/apple/internal/bundling_support.bzl b/apple/internal/bundling_support.bzl
@@ -377,7 +377,7 @@ def _validate_bundle_id(bundle_id):
             # handled by the split(), so just have to check for '-'.
             for i in range(len(part)):
                 ch = part[i]
-                if ch != "-" and not ch.isalnum():
+                if ch not in ["-", "_"] and not ch.isalnum():
                     fail("Invalid character(s) in bundle_id: \"%s\"" % bundle_id)
 
 # Define the loadable module that lists the exported symbols in this file.