-
Notifications
You must be signed in to change notification settings - Fork 264
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix to resolve error when compiling app intents indicating that it ex…
…pects all values to be statically allocated and resolved at compile time. This pulls all of the module names found from SwiftInfo when gathering the swiftconstfiles. This appears to work in the test targets set up, which do lean on the multiple module strategy. PiperOrigin-RevId: 589938532
- Loading branch information
1 parent
5368f97
commit 5668eb4
Showing
10 changed files
with
174 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 changes: 59 additions & 0 deletions
59
test/starlark_tests/resources/widget_configuration_intent.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
// Copyright 2023 The Bazel Authors. All rights reserved. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
import AppIntents | ||
|
||
enum RefreshInterval: String, AppEnum { | ||
case hourly, daily, weekly | ||
|
||
static var typeDisplayRepresentation: TypeDisplayRepresentation = "Refresh Interval" | ||
static var caseDisplayRepresentations: [RefreshInterval: DisplayRepresentation] = [ | ||
.hourly: "Every Hour", | ||
.daily: "Every Day", | ||
.weekly: "Every Week", | ||
] | ||
} | ||
|
||
struct FavoriteSoup: WidgetConfigurationIntent { | ||
static var title: LocalizedStringResource = "Favorite Soup" | ||
static var description = IntentDescription("Shows a picture of your favorite soup!") | ||
|
||
@Parameter(title: "Soup") | ||
var name: String? | ||
|
||
@Parameter(title: "Shuffle", default: true) | ||
var shuffle: Bool | ||
|
||
@Parameter(title: "Refresh", default: .daily) | ||
var interval: RefreshInterval | ||
|
||
static var parameterSummary: some ParameterSummary { | ||
When(\.$shuffle, .equalTo, true) { | ||
Summary { | ||
\.$name | ||
\.$shuffle | ||
\.$interval | ||
} | ||
} otherwise: { | ||
Summary { | ||
\.$name | ||
\.$shuffle | ||
} | ||
} | ||
} | ||
|
||
func perform() async throws -> some IntentResult & ProvidesDialog { | ||
return .result(dialog: "This is an intent with a computed property!") | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5668eb4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#2418