DownloadRegex respects local cache hits

Currently download_regex is ignored when a local cache hit occurs and uses the download_outputs flag to determine whether outputs should be downloaded. Make local cache hits respect the download_regex flag when set.

Bug: b/348708942
Test: https://paste.googleplex.com/5092424227749888
Change-Id: I6f540178e62b8f958c8ed8daf126a2f66c189ec8
GitOrigin-RevId: fa8c65d9bbdc42bbd03a9567525776b2cd211e06

internal/pkg/reproxy/action.go

@@ -700,6 +700,12 @@ func (a *action) getCachedResult(ctx context.Context) {
 		return
 	}
 	a.rec.LocalMetadata.ValidCacheHit = true
+	outDir := a.cmd.ExecRoot
+	outs, err := a.execContext.GetFlattenedOutputs()
+	if err != nil {
+		log.Errorf("%v: Unable to get flattened outputs from Action Result: %v", a.cmd.Identifiers.ExecutionID, err)
+	}
+	a.execContext.DownloadSpecifiedOutputs(a.excludeOutputsViaFilter(outs), outDir)
 }
 
 func (a *action) cacheLocal() {

internal/pkg/reproxy/server.go

@@ -840,6 +840,9 @@ func (s *Server) rerunAction(ctx context.Context, a *action) {
 }
 
 func (s *Server) runLERC(ctx context.Context, a *action) {
+	if a.downloadRegex != "" {
+		a.rOpt.DownloadOutputs = false
+	}
 	if err := a.createExecContext(ctx, s.REClient); err != nil {
 		// This cannot really happen, as the only error it checks for is cmd.Validate.
 		a.res = command.NewLocalErrorResult(err)