Skip to content

Commit

Permalink
Fix incorrectly formatted struct tags
Browse files Browse the repository at this point in the history
Test: Build succeeds with structtag nogo pass enabled
Bug: b/303263153
Change-Id: I03c2a78073d87b4ba5a0e00e73407f420ed6a732
GitOrigin-RevId: 5a067bf6f71605c6804efadd6880af52bacdd348
  • Loading branch information
bentekkie authored and copybara-github committed Jul 2, 2024
1 parent 2f46845 commit 2b819e0
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
12 changes: 6 additions & 6 deletions internal/pkg/inputprocessor/action/typescript/tsconfig_parser.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,23 +25,23 @@ import (
// Tsconfig encapusulates configuration in tsconfig.json for a Typescript project.
type Tsconfig struct {
// Extends is the parent tsconfig to be extended.
Extends string `json:extends`
Extends string `json:"extends"`
// Exclude is the list of files to be excluded.
Exclude []string `json:exclude`
Exclude []string `json:"exclude"`
// Files is the list of files to be included.
Files []string `json:files`
Files []string `json:"files"`
// Include is the list of directories to be included.
Include []string `json:include`
Include []string `json:"include"`
// References is list of project references.
References []Reference `json:references`
References []Reference `json:"references"`
// PaTsPathth is the path to this tsconfig.json file.
TsPath string
}

// Reference defines the path to a project reference.
type Reference struct {
// Path is the path to the project reference.
Path string `json:path`
Path string `json:"path"`
}

// parseTsconfig parses the tsconfig.json pointed to by Path.
Expand Down
2 changes: 1 addition & 1 deletion tools/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ TOOLS_NOGO = [
"@org_golang_x_tools//go/analysis/passes/sortslice:go_default_library",
"@org_golang_x_tools//go/analysis/passes/stdmethods:go_default_library",
"@org_golang_x_tools//go/analysis/passes/stringintconv:go_default_library",
# "@org_golang_x_tools//go/analysis/passes/structtag:go_default_library", # Re-enable when bad struct tags are fixed
"@org_golang_x_tools//go/analysis/passes/structtag:go_default_library",
# "@org_golang_x_tools//go/analysis/passes/testinggoroutine:go_default_library", # Re-enable when all test fails are called from test goroutine
"@org_golang_x_tools//go/analysis/passes/tests:go_default_library",
"@org_golang_x_tools//go/analysis/passes/unmarshal:go_default_library",
Expand Down

0 comments on commit 2b819e0

Please sign in to comment.