Followup: query xcode parameters from provider based on attributes #7266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bazel 8 introduced new provider located in apple_common module, which is not available in cquery context, so the implementation was updated to just find a provider with required attributes to make implementation also work for bazel 7 and older fixes bazelbuild#6604
github-actions
bot
added
product: CLion
3 tasks
ujohnny
reviewed
Feb 3, 2025
|
|
||
| final var scriptLines = Files.readAllLines(compilerSettings.getCompilerExecutable().toPath()); | ||
|
|
||
| assertContainsPattern("export DEVELOPER_DIR=/.*/Xcode.*.app/Contents/Developer", scriptLines); |
There was a problem hiding this comment.
I wonder why we do not have similar environment being injected for Apple Clang support in CLion.
ujohnny
approved these changes
Feb 3, 2025
github-actions
bot
removed
the
awaiting-review
LeFrosch
added a commit
to LeFrosch/intellij-bazel
that referenced
this pull request
Feb 3, 2025
…azelbuild#7266) * xcode: query xcode parameters from provider based on attributes Bazel 8 introduced new provider located in apple_common module, which is not available in cquery context, so the implementation was updated to just find a provider with required attributes to make implementation also work for bazel 7 and older fixes bazelbuild#6604 * use AspectStorageService to resolve the query file * check xcode environment variables in integration test * updated patterns to match CI values too --------- Co-authored-by: Evgenii Novozhilov <[email protected]>
ujohnny
pushed a commit
to ujohnny/intellij
that referenced
this pull request
Feb 7, 2025
…azelbuild#7266) * xcode: query xcode parameters from provider based on attributes Bazel 8 introduced new provider located in apple_common module, which is not available in cquery context, so the implementation was updated to just find a provider with required attributes to make implementation also work for bazel 7 and older fixes bazelbuild#6604 * use AspectStorageService to resolve the query file * check xcode environment variables in integration test * updated patterns to match CI values too --------- Co-authored-by: Evgenii Novozhilov <[email protected]> (cherry picked from commit 7a82dd6)
mai93
pushed a commit
that referenced
this pull request
Feb 7, 2025
* Remove dependency on rules_java in aspect BUILD file (#7270) * Simple test for Bazel 8 * External includes test for Bazel 8 * Virtual includes test for Bazel 8 * LLVM toolchain test for Bazel 8 * Added Bazel 8 to integration tests * Add bazel build output to test logs * Remove java dependencies in BUILD file * Enable bzlmod for tests * Fix aspect tests (cherry picked from commit 4e6b7c0) * Bump CLion to fixed version (#7269) I must have missed this during review. But the CLion version was pointing to the latest EAP, breaking builds due to sha mismatch. (cherry picked from commit 4c7153a) * Followup: query xcode parameters from provider based on attributes (#7266) * xcode: query xcode parameters from provider based on attributes Bazel 8 introduced new provider located in apple_common module, which is not available in cquery context, so the implementation was updated to just find a provider with required attributes to make implementation also work for bazel 7 and older fixes #6604 * use AspectStorageService to resolve the query file * check xcode environment variables in integration test * updated patterns to match CI values too --------- Co-authored-by: Evgenii Novozhilov <[email protected]> (cherry picked from commit 7a82dd6) * update CHANGELOG for v2025.01.21.0.2 --------- Co-authored-by: Daniel Brauner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup for #7193 after #7202 was merged.
Bazel 8 introduced new provider located in apple_common module,
which is not available in cquery context, so the implementation
was updated to just find a provider with required attributes to
make implementation also work for bazel 7 and older.