Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Re-realize aspect files after plugin update #6872

Merged

Conversation

tpasternak
Copy link
Collaborator

@tpasternak tpasternak commented Oct 10, 2024

Scenario

  1. Import the project correctly
  2. Download a new version of the plugin that contains new templates

Result:
The templates won't be re-realized, old java_info.bzl fil will persist

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: <please reference the issue number or url here>

Description of this change

@xuansontrinh xuansontrinh self-requested a review October 10, 2024 07:46
@tpasternak tpasternak marked this pull request as ready for review October 10, 2024 12:06
@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Oct 10, 2024
@tpasternak tpasternak merged commit 7c8d1f5 into bazelbuild:master Oct 10, 2024
6 checks passed
@tpasternak tpasternak deleted the rerealize-template-on-plugin-update branch October 10, 2024 14:19
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
Development

Successfully merging this pull request may close these issues.

4 participants