Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: fix tests for CLion #6870

Closed
wants to merge 22 commits into from
Closed

Chore: fix tests for CLion #6870

wants to merge 22 commits into from

Conversation

xuansontrinh
Copy link
Collaborator

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: <please reference the issue number or url here>

Description of this change

@xuansontrinh
[maintenance] copy java_info.bzl to project side to prepare for templ…
0907230 
…ating it.
@xuansontrinh
Merge branch 'master' into son/copy_java_info_to_project_side
35552df
@xuansontrinh
rename local path
863252b
@xuansontrinh
refactor a few files that use override_repository
ae42e03
@xuansontrinh
abc
194e4c4
@xuansontrinh
abc
45012ab
@xuansontrinh
revert change
a22f9e7
@xuansontrinh
revert changes
b4a7282
@xuansontrinh
Merge branch 'master' into son/copy_java_info_to_project_side
c029041
@xuansontrinh
Merge remote-tracking branch 'origin/master' into son/copy_java_info_…
6bbbc74 
…to_project_side

# Conflicts:
#	aspect/intellij_info_impl.bzl
@xuansontrinh
fix error for clion
1443a2a
@xuansontrinh
attempt to fix aspect test
10b801d
@xuansontrinh
Merge branch 'master' into son/copy_java_info_to_project_side
7f5a369
@xuansontrinh
update clwb BUILD file + fix ijwb visibility typo
8d6b4c4
@xuansontrinh
Merge remote-tracking branch 'origin/master' into son/copy_java_info_…
19b4650 
…to_project_side

# Conflicts:
#	aspect/intellij_info_impl.bzl
@xuansontrinh
updated logic
aa8feda
@xuansontrinh
disable tests
b4d56f0
@xuansontrinh
update logic
489e56a
@xuansontrinh
mute tests
91e1713
@xuansontrinh
Merge branch 'master' into son/copy_java_info_to_project_side
603d278
@xuansontrinh
try fixing clion tests
915c3e9
@xuansontrinh
Merge remote-tracking branch 'origin/master' into son/copy_java_info_…
c3ab27c 
…to_project_side

# Conflicts:
#	base/src/com/google/idea/blaze/base/sync/aspects/strategy/AspectRepositoryProvider.java
#	clwb/tests/integrationtests/com/google/idea/blaze/clwb/base/TestAspectRepositoryProvider.java
@xuansontrinh xuansontrinh marked this pull request as ready for review October 9, 2024 12:12
@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Oct 9, 2024
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Oct 9, 2024
@xuansontrinh xuansontrinh deleted the son/fix-tests branch October 9, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mai93 mai93 Awaiting requested review from mai93 mai93 is a code owner

@tpasternak tpasternak Awaiting requested review from tpasternak tpasternak is a code owner

@agluszak agluszak Awaiting requested review from agluszak agluszak is a code owner

Assignees

@ujohnny ujohnny

@tpasternak tpasternak

@mai93 mai93

Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
Bazel IntelliJ Plugin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xuansontrinh @ujohnny @tpasternak @mai93