New Sync View

[LeFrosch]

Adds the option to use the platform sync view instead of the bazel custom one. Errors are also collected using BEP in the new view to improve the quality of reported issues.

Registry key: bazel.new.sync.view

Uses the platform sync view to display progress. However, progress no longer follows a tree structure.

The platform sync view offers sufficient space for BEP's detailed error messages.

[LeFrosch]

Rebased master

[mai93]

why is this better than the existing way? is the plan to make it the default?

[LeFrosch]

@mai93 The Idea was to show error messages received by BEP rather than parsing the command line output to increase the quality and relevance of reported errors. In my option, the sync and build view provided by the platform was better suited for displaying these longer messages. Furthermore, I hope that using the platform sync view can save us some maintenance work in the long run, since it is maintained by the platform team.

With regard to making this view the default, this depends, of course, on the feedback we receive. If it is well perceived, I see no reason for not doing so. But maybe it makes sense to make it opt-in in the beginning.

[mai93]

Thanks for the explanation! I'd propose guarding it with an experiment instead and enabling it incrementally because we have a lot of features added for specific users behind a key and we never got a sense if they are ready for general rollout.

[tpasternak]

Btw please hold on, does it work with query sync?

[LeFrosch]

@tpasternak I am not sure how the sync UI for query sync works but the new sync view is just a scope that can be added to the BlazeContext and processes IssueOutputs. If the view works well for regular sync I was planning to also adopt it for running builds and maybe we can also use it for query sync.

[tpasternak]

Ok, you can just add use_query_sync: true to the projectview file to test