Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issues when bazel is used alongside cmake #6770

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

LeFrosch
Copy link
Collaborator

Description of this change

If the file already belongs to a cmake project the bazel import fix is also shown by the PSW and if the project is reopend some classes are registered twice.

image

@LeFrosch LeFrosch marked this pull request as ready for review September 19, 2024 13:46
@github-actions github-actions bot added product: CLion CLion plugin awaiting-review Awaiting review from Bazel team on PRs labels Sep 19, 2024
@LeFrosch
Copy link
Collaborator Author

CC @TomatorCZ

@tpasternak
Copy link
Collaborator

@LeFrosch can we move it to base? It's also a problem with non-cmake build tools

#6757

@LeFrosch
Copy link
Collaborator Author

LeFrosch commented Oct 7, 2024

@TomatorCZ PSW for bazel seems broken in 243 not sure what causes this. As far as I can tell com.google.idea.blaze.clwb.CLionNotificationProvider#getWidgetStatus returns Status.OK but banner is still shown.

@LeFrosch
Copy link
Collaborator Author

LeFrosch commented Oct 7, 2024

@LeFrosch can we move it to base? It's also a problem with non-cmake build tools

#6757

@tpasternak The normal banner is a bit different and only checks if the current project is bazel or not. Also it should be possible to dismiss the default banner.

@tpasternak
Copy link
Collaborator

Sorry I didn't get it

@LeFrosch
Copy link
Collaborator Author

LeFrosch commented Oct 9, 2024

A required fix in CLion is on master - waiting for next EAP due to API changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review Awaiting review from Bazel team on PRs product: CLion CLion plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants